TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: re… #963
Conversation
|
[approve ci] |
|
Should we change this to an ink_relase_assert() or an ink_abort() ? |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/688/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/584/ for details. |
|
Yes, it seems like the null check is only dead if the assert always occurred. Otherwise running without debug enabled will not catch the issue and cause a more mysterious crash later. |
ngara
force-pushed
the
TS-4815
branch
2 times, most recently
from
7687c89 to
8947c56
Compare
|
Thanks for the feedback. Updated to use ink_release_assert which will always execute, and ready to review again. |
|
This pull request should not be merged in. Handling it with TS-4860 instead. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/793/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/689/ for details. |
|
@ngara Maybe I'm reading this wrong, but it looks like we still have 3 commits in this PR. If that's the case, can you please squash that down into a single commit? No reason to have the 2 previous versions in the git commit history. |
…turn TS_ERR_PARAMS;
|
Alright, I cleaned up my mess. Here's just the single commit. |
5 participants
TS-4815 - CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;