Merged
Conversation
zwoop
previously approved these changes
Jun 8, 2023
SolidWallOfCode
force-pushed
the
swoc-wccp-precleanup
branch
2 times, most recently
from
a7d7dfc to
164b4dc
Compare
SolidWallOfCode
force-pushed
the
swoc-wccp-precleanup
branch
from
164b4dc to
f099330
Compare
zwoop
approved these changes
Jun 8, 2023
JosiahWI
reviewed
Jun 9, 2023
| WccpConfig.cc WccpEndPoint.cc WccpMsg.cc WccpStatic.cc | ||
| ) | ||
|
|
||
| target_link_libraries(wccp PRIVATE libswoc) |
Contributor
There was a problem hiding this comment.
Why are you linking swoc already? I don't see any reference to swoc in these changes.
Member
Author
There was a problem hiding this comment.
Because it was handier to add the CMake earlier than later.
bryancall
pushed a commit
to bryancall/trafficserver
that referenced
this pull request
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the WCCP code to be baseline equivalent to modern ATS core code, in preparation for updating to libswoc.