First stab at cleaning up experimental.h deps#9812
Merged
zwoop merged 1 commit intoapache:masterfrom Jun 27, 2023
Merged
Conversation
zwoop
force-pushed
the
FirstStepOnExperimental
branch
3 times, most recently
from
108cbe7 to
b810cd2
Compare
zwoop
force-pushed
the
FirstStepOnExperimental
branch
from
b810cd2 to
c91eb01
Compare
Contributor
Author
|
[approve ci centos] |
ywkaras
reviewed
Jun 23, 2023
| #define TS_HRTIME_USECOND (1000 * TS_HRTIME_NSECOND) | ||
| #define TS_HRTIME_NSECOND (1LL) | ||
|
|
||
| #define TS_HRTIME_SECONDS(_x) ((_x)*TS_HRTIME_SECOND) |
Contributor
There was a problem hiding this comment.
Why not constexpr TSHRTime TS_HRTIME_SECONDS(TSHRTIME nsec) { return nsec * TS_HRTIME_SECOND); } ?
bryancall
approved these changes
Jun 26, 2023
Contributor
bryancall
left a comment
bryancall
left a comment
There was a problem hiding this comment.
You can switch the defines to constexpr. Still better than before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.