Merged
Conversation
JosiahWI
force-pushed
the
feat/cmake-zlib
branch
4 times, most recently
from
5443e1b to
3568e13
Compare
bryancall
added
CMake
cmcfarlen
previously approved these changes
Jun 12, 2023
Contributor
|
are we sure this doesn't break builds without zlib that would have worked with the CPP conditionals? |
Contributor
Author
|
I just tried building without it, and autotools gave me an error that it could not find zlib. |
Zlib is required to compile ATS. We don't need to keep this option around.
JosiahWI
force-pushed
the
feat/cmake-zlib
branch
from
3568e13 to
ca0c43e
Compare
cmcfarlen
approved these changes
Jun 13, 2023
bryancall
pushed a commit
to bryancall/trafficserver
that referenced
this pull request
Jun 14, 2023
Zlib is required to compile ATS. We don't need to keep this option around.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zlib is required to compile ATS. We don't need to keep this option around.