Add TSHttpTxnNextHopPortGet, add NEXT-HOP to header rewrite#9829
Merged
traeak merged 2 commits intoapache:masterfrom Jun 29, 2023
Merged
Add TSHttpTxnNextHopPortGet, add NEXT-HOP to header rewrite#9829traeak merged 2 commits intoapache:masterfrom
traeak merged 2 commits intoapache:masterfrom
Conversation
shukitchan
requested changes
Jun 12, 2023
Contributor
shukitchan
left a comment
shukitchan
left a comment
There was a problem hiding this comment.
I think you are still working on this.
But please update the plugin documentation on the new changes as well. Thanks.
traeak
changed the title
add header rewrite support for NEXT-HOP:HOST and NEXT-HOP:PORT
Contributor
Author
it was just wip. should be documented and everything. |
shukitchan
requested changes
Jun 28, 2023
Contributor
shukitchan
left a comment
shukitchan
left a comment
There was a problem hiding this comment.
Also, I think we need to update documentation for header rewrite plugin as well.
|
|
||
| #include <ts/ts.h> | ||
|
|
||
| .. function:: const char *TSHttpTxnNextHopPortGet(TSHttpTxn txnp) |
Contributor
There was a problem hiding this comment.
The return type is int instead. A typo here?
shukitchan
approved these changes
Jun 28, 2023
zwoop
pushed a commit
that referenced
this pull request
Jul 3, 2023
* add TSHttpTxnNextHopPortGet to api add header rewrite support for NEXT-HOP:HOST and NEXT-HOP:PORT * add to header rewrite documentation and other doc fixes --------- Co-authored-by: Brian Olsen <bolsen149@comcast.com> (cherry picked from commit 0363ab6)
Contributor
|
Slightly unorthodox to include this in a patch release, but alas, we're not doing 9.3.0 release, and this seems generally useful and safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds TSHttpTxnNextHopPortGet in addition to TSHttpTxnNextHopNameGet and adds to header_rewrite as %{NEXT-HOP:HOST} and %{NEXT-HOP:PORT} for SEND_REQUEST_HDR_HOOK.