Untangle some classes in iocore#9838
Merged
moonchen merged 1 commit intoapache:masterfrom Jun 29, 2023
Merged
Conversation
Contributor
moonchen
commented
Jun 13, 2023
moonchen
commented
- Isolate the following classes into their own files
- NetEvent
- NetHandler
- NetVCOptions
- PollCont
- AcceptOptions
- Fix some includes other files to compile cleanly
moonchen
force-pushed
the
untangle-iocore-2
branch
from
c410736 to
34f8d91
Compare
maskit
reviewed
Jun 14, 2023
maskit
reviewed
Jun 14, 2023
moonchen
force-pushed
the
untangle-iocore-2
branch
2 times, most recently
from
a88300c to
981c790
Compare
Contributor
Author
|
[approve ci debian] |
- Isolate the following classes into their own files - NetEvent - NetHandler - NetVCOptions - PollCont - AcceptOptions - Fix some includes other files to compile cleanly
moonchen
force-pushed
the
untangle-iocore-2
branch
from
981c790 to
b27b4f6
Compare
Contributor
Author
|
Rebased |
ywkaras
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.