Check for 128bit CAS in CMake build#9851
Merged
bneradt merged 1 commit intoapache:masterfrom Jun 15, 2023
Merged
Conversation
This adds a script that sets the following variables: TS_HAS_128BIT_CAS, TS_NEEDS_MCX16_FOR_CAS. The source code for the compile check was taken from the autotools build with some minor modifications (removed void arg to main, removed extraneous semicolon, brought main body back to 1 level of indentation).
JosiahWI
added
Build
cmcfarlen
approved these changes
Jun 15, 2023
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
I'll approve this but I wonder if this is necessary at all. Are there any compilers or architectures that don't support this or is there even a reason to make a distinction anymore?
Contributor
Author
|
It appears that -mcx16 is necessary on x86 systems, but we may always be able to build with that option. https://gcc.gnu.org/onlinedocs/gcc-13.1.0/gcc/x86-Options.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a script that sets the following variables: TS_HAS_128BIT_CAS, TS_NEEDS_MCX16_FOR_CAS. The source code for the compile check was taken from the autotools build with some minor modifications (removed void arg to main, removed extraneous semicolon, brought main body back to 1 level of indentation).
Testing Note: I checked the behavior of both paths through the module by simulating the first check failing, but I cannot verify that the first check will actually fail.