Add support for async requests for wasm plugin#9896
Add support for async requests for wasm plugin#9896shukitchan merged 10 commits intoapache:masterfrom
Conversation
|
[approve ci autest] |
|
There are quite a lot of materials on async requests in a wasm module in this talk - https://events.istio.io/istiocon-2021/slides/c8p-ExtendingEnvoyWasm-EdSnible.pdf |
| TSDebug(WASM_DEBUG_TAG, "[%s] no context or not yet reenabled transaction", __FUNCTION__); | ||
|
|
||
| if (result == 0) { | ||
| TSHttpTxnReenable(txnp, TS_EVENT_HTTP_CONTINUE); |
There was a problem hiding this comment.
Why does context->reenable_txn_ not need to get set here?
There was a problem hiding this comment.
Yes. I should do that. Will make a change.
doc/admin-guide/plugins/wasm.en.rst
Outdated
|
|
||
| * Getting and setting trailer request and response header | ||
| * Getting and setting HTTP/2 frame meta data | ||
| * Support asynchronous request call in the start handler function of the transaction lifecycle |
There was a problem hiding this comment.
Should this be in limitations? I thought this is a new feature but adding it here implies it is not supported
There was a problem hiding this comment.
Yes. This is a new feature but there is no easy way for us to support async request inside the "start" handler function of the plugin lifecycle.
Let me reword this a bit.
|
It is ready for review again. thanks. |
|
[approve ci clang-format] |
|
[approve ci autest] |
3 participants
No description provided.