Remove socket option globals. #9935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
force-pushed
the
remove-sockopt-globals
branch
2 times, most recently
from
ee6436d to
c4c687e
Compare
Remove the SOCKOPT_ON and SOCKOPT_OFF globals. These weren't used consistently and can easily be replaced by a helper function. Apply the new helper function everywhere that toggles socket options on. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
force-pushed
the
remove-sockopt-globals
branch
from
c4c687e to
109b132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the SOCKOPT_ON and SOCKOPT_OFF globals. These weren't used consistently and cand easily be replaced by a helper function. Apply the new helper function everywhere that toggles socket options on.