Support static libtsfile builds - #894
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DuckDB extensions and other self-contained integrations need to link TsFile statically instead of depending on a runtime
libtsfileshared library.Previously, the C++ build always declared
libtsfileas aSHAREDtarget, soBUILD_SHARED_LIBS=OFFdid not affect it.Changes
TSFILE_BUILD_SHAREDCMake option.ONto preserve the existing behavior.OFFto generatelibtsfile.aortsfile.lib.TSFILE_STATIChandling for MSVC symbol visibility.TSFILE_STATICto consumers linking the CMaketsfiletarget.libtsfile.dllfor Windows static builds.