Skip to content

[CMake] Format static symbol helper condition#628

Merged
tqchen merged 1 commit into
apache:mainfrom
tqchen:tvm-ffi-format-static-symbol-helper
Jun 17, 2026
Merged

[CMake] Format static symbol helper condition#628
tqchen merged 1 commit into
apache:mainfrom
tqchen:tvm-ffi-format-static-symbol-helper

Conversation

@tqchen

@tqchen tqchen commented Jun 17, 2026

Copy link
Copy Markdown
Member

Apply cmake-format to the condition introduced for hiding symbols from linked static libraries.

Validation:

  • pre-commit run cmake-format --files cmake/Utils/Library.cmake
  • git diff --check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reformats a conditional statement in the 'tvm_ffi_hide_static_linked_lib_symbols' function within 'cmake/Utils/Library.cmake' to adjust line wrapping. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@tqchen
tqchen merged commit 3d27433 into apache:main Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants