[CORE] Staging Object Tying Feature - #696
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
tqchen
force-pushed
the
tvm-ffi-r1-dormant-object-tying
branch
from
August 1, 2026 01:48
11c5c52 to
1729a1d
Compare
Retain the complete Python object-tying implementation and custom allocator API, but deliberately keep canonical wrapper reuse dormant for the current compatibility stage. Public C++, Python-dataclass, and Rust object construction continue to use their matching legacy allocation and deletion paths, and canonical detection returns false. This staged rollout lets downstream FlashInfer upgrade without breaking previously generated caches, keeps the compatibility change compact by changing the activation and allocation boundary instead of removing the implementation, and preserves a clean path for a later coordinated object-tying activation. Restore legacy wrapper identity and reference-count expectations while retaining the activation-only tying suite as skipped coverage until that rollout.
tqchen
force-pushed
the
tvm-ffi-r1-dormant-object-tying
branch
from
August 1, 2026 01:49
1729a1d to
89031a1
Compare
Member
Author
|
Post-publication FlashInfer confirmation against published head
The detailed compatibility investigation and benchmark matrix remain on the task issue. |
cyx-6
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Object tying remains compiled but is deliberately staged dormant: canonical-wrapper detection returns false, while C++, Python-defined dataclasses, and Rust objects continue to use matching legacy allocation and deletion paths.
This staging has three goals:
Legacy wrapper identity and reference-count expectations are restored, while activation-only tying tests remain as skipped coverage for the later rollout.
Testing