[REFACTOR][RUST] Keep mutate dispatch state on the dispatcher - #728
Merged
Conversation
Seven-Streams
approved these changes
Sep 2, 2026
tqchen
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes typed structural mutation dispatch own its pass state directly.
Previously,
#[dispatch(mutate)]separated the dispatch object from aStatestored insideMutateCallbacks, requiring handlers to access state throughmutator.state()ormutator.state_mut().Now the state lives naturally on the dispatch object:
The responsibilities are now separated as follows:
#[dispatch(mutate)]selects the matching typed handler.Mutatorprovides recursion, default mutation, variable remapping, and the current definition region.selfduring recursion creates a normal Rust mutable reborrow and avoids hidden aliasing through raw pointers.CallbackMutator<State>andMutateCallbacks.The Rust guide and structural-mutation tests have been updated to use the new API. All relevant Rust tests, including the 47 structural-mutation tests, pass.