[BugFix] Fix PopenWorker Memory Leak#10874
Closed
zxybazh wants to merge 3 commits intoapache:mainfrom
Closed
Conversation
shingjan
reviewed
Apr 1, 2022
junrushao
reviewed
Apr 1, 2022
tqchen
approved these changes
Apr 1, 2022
tqchen
requested changes
Apr 1, 2022
|
|
||
| lock = threading.Lock() | ||
|
|
||
| def get_reader(): |
Member
There was a problem hiding this comment.
sorry that I actually do not fully get why fdopen in a subfunction helps. can you elaborate why? (with an example)
Member
Author
There was a problem hiding this comment.
Hi TQ, it does not acutally help that we put fdopen into a subfunction. The cause of the memory leak is acutally reusing the same After checking the proccess status, I found that this fix does not really fix the problem because it only caused the process to suicide which avoided memory leak.reader and writer. The change is acutally to create new reader and writer everytime instead of reusing the same ones to avoid leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During tuning of meta schedule I found a memory leak from PopenWorker. The cause is related to the use of reader and writer inside of the class. I rewrote the Popenworker to create a new reader / writer before usage. There might slightly impact the overhead of tuning but avoids the memory leak.
CC: @tqchen @junrushao1994 @shingjan