[MetaSchedule] Reduce Local Builder Memory Usage#11074
Merged
masahi merged 1 commit intoapache:mainfrom Apr 21, 2022
Merged
Conversation
Member
|
@zxybazh Thanks you for effort! Would you mind also doing this for RPCRunner and LocalRunner? Thanks a lot! |
Member
Author
Thanks for the suggestion. I would like to keep RPCRunner and LocalRunner the same because:
Therefore, let's keep the runners the way they are and apply this fix for local builder mem usage reduction. |
shingjan
approved these changes
Apr 21, 2022
shingjan
left a comment
shingjan
left a comment
There was a problem hiding this comment.
Overall LGTM. Just some nits. Thanks for sending this fix!
Retrigger CI. Address issues. Retrigger CI.
zxybazh
force-pushed
the
bugfix/2022-04-19/popen-pool-restart
branch
from
86e0afa to
bb55bfe
Compare
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
Retrigger CI. Address issues. Retrigger CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce a fix to restart Popen pool in every usage. It's a current work around to avoid significant memory usage by Popen workers reused during tuning following #10874. Considering the time cost of postprocessors and evolutionary search, current implementation will not increase the overhead by a large margin in practice.
CC: @tqchen @junrushao1994 @shingjan