Skip to content

[onnx][topi]fix group_conv3d caculate error #12500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 1 commit into from
Aug 19, 2022
Merged

[onnx][topi]fix group_conv3d caculate error #12500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/tvm/topi/x86/conv3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ def _conv3d_ndhwc(cfg, data, kernel, strides, padding, dilation, groups, out_dty
# pack kernel
shape = (
num_filter // oc_bn,
in_channel // groups // ic_bn,
in_channel // groups // ic_bn if (in_channel // groups // ic_bn) else 1,
kernel_depth,
kernel_height,
kernel_width,
Expand Down Expand Up @@ -392,7 +392,7 @@ def _conv3d_ncdhw(cfg, data, kernel, strides, padding, dilation, layout, groups,
# pack kernel
shape = (
num_filter // oc_bn,
in_channel // groups // ic_bn,
in_channel // groups // ic_bn if (in_channel // groups // ic_bn) else 1,
kernel_depth,
kernel_height,
kernel_width,
Expand Down
2 changes: 1 addition & 1 deletion tests/python/frontend/onnx/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2967,7 +2967,7 @@ def repeat(num, dims):
)

# TODO(jwfromm): Merge with other tests once group_conv3d is supported.
for dims in [1, 2]:
for dims in [1, 2, 3]:
# Group Convolution
verify_conv(
(1, 8) + repeat(5, dims),
Expand Down