[onnx][topi]fix group_conv3d caculate error#12500
Merged
masahi merged 1 commit intoapache:mainfrom Aug 19, 2022
chengven027:conv3d_group.fix
Merged
[onnx][topi]fix group_conv3d caculate error#12500masahi merged 1 commit intoapache:mainfrom chengven027:conv3d_group.fix
masahi merged 1 commit intoapache:mainfrom
chengven027:conv3d_group.fix
Conversation
Contributor
Author
|
Why the bot will auto edit the comment? sorry, I don`t know why the bot always cc at you @blackkker |
Contributor
|
it's weird. |
Contributor
Member
|
You're right it is #10317, editing the PR body is how it works. I added some description to #10317 to maybe clear some stuff up. @chengven027-intellif don't worry about the @s, they're opt-in for people interested in various topics |
Contributor
Author
|
@masahi Could you help to review this PR? thanks. |
masahi
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When I run group_conv3d test. I set the
groupequalin_channel. Then the op result is 100% error.The error is in 'conv3d.py.':
in_channel // groups // ic_bn. the result is 0. Because it is the shape of kernel. Can`t equal 0. So I set it equal 1 if the result is 0.Then my test successed.
cc @blackkker