[CI] github_cc_reviewers: Catch all exceptions so all reviewers can be processed#12578
Merged
driazati merged 2 commits intoapache:mainfrom Aug 25, 2022
Merged
[CI] github_cc_reviewers: Catch all exceptions so all reviewers can be processed#12578driazati merged 2 commits intoapache:mainfrom
driazati merged 2 commits intoapache:mainfrom
Conversation
driazati
approved these changes
Aug 24, 2022
Member
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
nice catch and thanks for the fix!
Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…e processed (apache#12578) In a recent change, `github.post` throws `RuntimeError` instead of `HTTPError` when the requested reviewer isn't a project collaborator. This prevents other reviewers to be added to the PR, for example, https://github.com/apache/tvm/runs/8001367110?check_suite_focus=true. This PR changes the caller to catch any exception so the execution won't be interrupted. Co-authored-by: driazati <9407960+driazati@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent change,
github.postthrowsRuntimeErrorinstead ofHTTPErrorwhen the requested reviewer isn't a project collaborator. This prevents other reviewers to be added to the PR, for example, https://github.com/apache/tvm/runs/8001367110?check_suite_focus=true.This PR changes the caller to catch any exception so the execution won't be interrupted.
cc @Mousius @areusch @driazati @gigiblender