Skip to content

[CI] github_cc_reviewers: Catch all exceptions so all reviewers can be processed #12578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
driazati merged 2 commits into from
Aug 25, 2022
Merged

[CI] github_cc_reviewers: Catch all exceptions so all reviewers can be processed #12578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7db6669
Catch all exceptions so other reviewers can be processed
yelite Aug 24, 2022
d39ce80
Update tests/scripts/github_cc_reviewers.py
yelite Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/scripts/github_cc_reviewers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
# specific language governing permissions and limitations
# under the License.

import sys
import os
import json
import argparse
Expand Down Expand Up @@ -106,5 +107,8 @@ def find_reviewers(body: str) -> List[str]:
for reviewer in to_add:
try:
github.post(f"pulls/{number}/requested_reviewers", {"reviewers": [reviewer]})
except error.HTTPError as e:
except KeyboardInterrupt:
sys.exit()
except (RuntimeError, error.HTTPError) as e:
# Catch any exception so other reviewers can be processed
print(f"Failed to add reviewer {reviewer}: {e}")