Skip to content

[Unity][Analysis] Reshape TIR detection with iter-map-simplify - #15099

Merged
masahi merged 1 commit into
apache:unityfrom
MasterJH5574:unity-dev/2023-06-13-reshape-detect-dyn
Jun 14, 2023
Merged

[Unity][Analysis] Reshape TIR detection with iter-map-simplify#15099
masahi merged 1 commit into
apache:unityfrom
MasterJH5574:unity-dev/2023-06-13-reshape-detect-dyn

Conversation

@MasterJH5574

Copy link
Copy Markdown
Contributor

This PR supports the reshape PrimFunc detection analysis with iter-map-simplify, in order to better support TIR functions with dynamic variables, which is not well handled before.

Meanwhie, this PR also keeps the existing analysis logic, so that we are still able to cover the cases like reshape with raggedness.

Unit tests for reshape are added to ensure correctness.

@tvm-bot

tvm-bot commented Jun 14, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@tvm-bot

tvm-bot commented Jun 14, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: analysis, branch: unity See #10317 for details

Generated by tvm-bot

@MasterJH5574 MasterJH5574 changed the title [Analysis] Reshape TIR detection with iter-map-simplify (#251) [Unity][Analysis] Reshape TIR detection with iter-map-simplify Jun 14, 2023
@MasterJH5574
MasterJH5574 force-pushed the unity-dev/2023-06-13-reshape-detect-dyn branch from e7d10e5 to 90c35c5 Compare June 14, 2023 01:34
@MasterJH5574
MasterJH5574 force-pushed the unity-dev/2023-06-13-reshape-detect-dyn branch from 90c35c5 to af1275d Compare June 14, 2023 17:56
This PR supports the reshape PrimFunc detection analysis with
iter-map-simplify, in order to better support TIR functions with dynamic
variables, which is not well handled before.

Meanwhie, this PR also keeps the existing analysis logic, so that we are
still able to cover the cases like reshape with raggedness.

Unit tests for reshape are added to ensure correctness.
@MasterJH5574
MasterJH5574 force-pushed the unity-dev/2023-06-13-reshape-detect-dyn branch from af1275d to bcae814 Compare June 14, 2023 19:31
@masahi
masahi merged commit 990c768 into apache:unity Jun 14, 2023
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jun 22, 2023
…e#15099)

This PR supports the reshape PrimFunc detection analysis with
iter-map-simplify, in order to better support TIR functions with dynamic
variables, which is not well handled before.

Meanwhie, this PR also keeps the existing analysis logic, so that we are
still able to cover the cases like reshape with raggedness.

Unit tests for reshape are added to ensure correctness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants