[Unity][CUTLASS] Support out_dtype = "float32" for FasterTransformer kernel - #15377
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
approved these changes
Jul 21, 2023
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 24, 2023
…r kernel (apache#15377) Support out_dtype = "float32" for FasterTransformer kernel
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 27, 2023
…r kernel (apache#15377) Support out_dtype = "float32" for FasterTransformer kernel
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 30, 2023
…r kernel (apache#15377) Support out_dtype = "float32" for FasterTransformer kernel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FT kernel requires the output pointer type to be fp16, so we haven't supported offloading
matmulwithout_dtype="float32". But if such matmul is immediately followed by a cast to fp16, we can match and replace the wholematmul -> castwith the FT kernel.Such case arises if a user wants to do fp32 accum during matmul. It turns out the FT kernel always does fp32 accumulation internally regardless of the output dtype, so we are not losing any precision by offloading
matmul(..., out_dtype = "float32") -> castto the fp16 A - int B FT kernel.@vinx13 @sunggg @yzh119