[Unity][DLight] Fix Reduction Rule#15412
Merged
Merged
Conversation
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
force-pushed
the
fix_dl_reduction
branch
from
July 26, 2023 11:55
1e2d0e0 to
ca223c9
Compare
This PR fixes a correctness issue when the epilogue length is different with the `len_tx`.
Hzfengsy
force-pushed
the
fix_dl_reduction
branch
from
July 26, 2023 13:42
ca223c9 to
1154e4e
Compare
MasterJH5574
approved these changes
Jul 26, 2023
MasterJH5574
left a comment
MasterJH5574
left a comment
Contributor
There was a problem hiding this comment.
I see. Thanks for the fix. I was assuming the spatial loop is divided into bx and tx only, and was not aware that there could be another loop which is not bound to any thread (e.g., the loop with length 8 in your added test case).
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jul 30, 2023
This PR fixes a correctness issue when the epilogue length is different with the `len_tx`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a correctness issue when the epilogue length is different with the
len_tx.cc @junrushao @MasterJH5574