Skip to content

[Unity] cuda graph support for cublas#15435

Merged
masahi merged 2 commits into
apache:unityfrom
sunggg:2023-Jul/fix-cublas-to-use-cuda-graph
Jul 30, 2023
Merged

[Unity] cuda graph support for cublas#15435
masahi merged 2 commits into
apache:unityfrom
sunggg:2023-Jul/fix-cublas-to-use-cuda-graph

Conversation

@sunggg

@sunggg sunggg commented Jul 28, 2023

Copy link
Copy Markdown
Contributor

This PR enables cuda graph with cublas.

@tvm-bot

tvm-bot commented Jul 28, 2023

Copy link
Copy Markdown
Collaborator

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Comment thread src/runtime/contrib/cublas/cublas.cc Outdated
@masahi
masahi merged commit d3d350b into apache:unity Jul 30, 2023
@LeiWang1999

Copy link
Copy Markdown
Contributor

hi @masahi , @sunggg , would you mind providing some detailed information about the CUDA graph? I'm currently attempting to integrate cuDNN into Relax via BYOC, and any insights would be greatly appreciated.

@masahi

masahi commented Aug 2, 2023

Copy link
Copy Markdown
Member

What information do you need?

@LeiWang1999

Copy link
Copy Markdown
Contributor

What information do you need?

@masahi thanks,
Trustfully, I'm not sure about the purpose of the cuda graph, is this a new concept that introduced by unity?

@masahi

masahi commented Aug 2, 2023

Copy link
Copy Markdown
Member

No, it is a standard CUDA concept to reduce host-side overhead. See
https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#cuda-graphs
https://www.nvidia.com/ja-jp/on-demand/session/gtcspring23-s51211/

@LeiWang1999

Copy link
Copy Markdown
Contributor

@masahi thanks! seems sth like multi stream parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants