[Relax] Fix int64 row index cast in GPU multinomial sampling - #19902
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the parallel_sampling_from_prob function in python/tvm/relax/backend/gpu_generic/sampling.py to explicitly cast row_indices[bx, 0] to an int64 type using T.Cast when assigning it to row_idx. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
After the tirx refactor, a `T.let` binding no longer implicitly casts
its right-hand side to the annotated dtype. In
`gpu_multinomial_from_uniform`, `row_idx` is annotated `int64` but is
loaded from the `row_indices` buffer, whose dtype is the configurable
`sample_indices_dtype` and may be `int32`. Relying on the let annotation
to widen the value is no longer valid and yields a dtype mismatch.
Wrap the load in an explicit `T.Cast("int64", ...)` so the row index is
always converted to the annotated int64 type regardless of
`sample_indices_dtype`, and update the expected module in
`test_dispatch_multinomial_from_uniform_gpu` to match.
MasterJH5574
force-pushed
the
relax-sampling-int64-cast
branch
from
June 29, 2026 14:14
6ccfcde to
de89fb1
Compare
tlopex
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the tirx refactor, a
T.letbinding no longer implicitly castsits right-hand side to the annotated dtype. In
gpu_multinomial_from_uniform,row_idxis annotatedint64but isloaded from the
row_indicesbuffer, whose dtype is the configurablesample_indices_dtypeand may beint32. Relying on the let annotationto widen the value is no longer valid and yields a dtype mismatch.
Wrap the load in an explicit
T.Cast("int64", ...)so the row index isalways converted to the annotated int64 type regardless of
sample_indices_dtype.