[Improvement] Exit on OutOfMemoryError

[xianjingfeng]

Code of Conduct

• I agree to follow this project's Code of Conduct

Search before asking

• I have searched in the issues and found no similar issues.

What would you like to be improved?

At present, if OutOfMemoryError is encountered, server will not exit.

How should we improve?

Add -XX:+ExitOnOutOfMemoryError and -XX:+CrashOnOutOfMemoryError to JVM argments.

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[xianjingfeng]

PTAL @jerqi @zuston @advancedxy

[roryqi]

PTAL @jerqi @zuston @advancedxy

Do we need dump the memory when OOM occurs？

[xianjingfeng]

PTAL @jerqi @zuston @advancedxy

Do we need dump the memory when OOM occurs？

The dump file maybe too big and disk space may be not enough to store it. So users should specify the path to store it.

[advancedxy]

PTAL @jerqi @zuston @advancedxy

Do we need dump the memory when OOM occurs？

The dump file maybe too big and disk space may be not enough to store it. So users should specify the path to store it.

+1 from my side. oom dump should be an opt-in feature. The bin/start-shuffle-server.sh may handle that as a cli argument or env variable.

[zuston]

The bin/start-shuffle-server.sh may handle that as a cli argument or env variable.

Good idea. This should be supported.

[AdarshRawat1]

Requesting permission to contribute to this feature. . Can you please advise on how I can get involved? Thanks

[roryqi]

Requesting permission to contribute to this feature. . Can you please advise on how I can get involved? Thanks

I assigned this issue to you.
@AdarshRawat1 You can refer to https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
If you have any question, you can ask me.

[AdarshRawat1]

Requesting permission to contribute to this feature. . Can you please advise on how I can get involved? Thanks

I assigned this issue to you. @AdarshRawat1 You can refer to https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md If you have any question, you can ask me.

@jerqi Could you kindly provide me with additional resources and guidance [files to change, tests to perform], please?

[roryqi]

1 files to change

https://github.com/apache/incubator-uniffle/blob/master/bin/start-coordinator.sh
https://github.com/apache/incubator-uniffle/blob/master/bin/start-shuffle-server.sh

2 test to perform
You build package and unzip it, set environment variable (JAVA_HOME and HADOOP_HOME) and run the cmd
sh bin/start-shuffle-server.sh and sh bin/start-coordinator.sh. If the process start successfully, the change is ok.

[roryqi]

@AdarshRawat1 Do you need any other help from me?

[AdarshRawat1]

@AdarshRawat1 Do you need any other help from me?

@jerqi I’m currently occupied with my mid-term exams. Once I’m done with them, I’ll address this issue. I would appreciate your valuable guidance at that time. Thank you.

[roryqi]

@AdarshRawat1 Do you need any other help from me?

@jerqi I’m currently occupied with my mid-term exams. Once I’m done with them, I’ll address this issue. I would appreciate your valuable guidance at that time. Thank you.

@AdarshRawat1 Do you want to continue this issue?