[#999] improvement: apply REST principles in the urls of the http interfaces - #1000
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1000 +/- ##
============================================
+ Coverage 53.67% 54.84% +1.17%
- Complexity 2523 2525 +2
============================================
Files 381 362 -19
Lines 21648 19291 -2357
Branches 1800 1799 -1
============================================
- Hits 11620 10581 -1039
+ Misses 9322 8078 -1244
+ Partials 706 632 -74
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@slfan1989 @yl09099 Will this change affect the module cli? Do we need another modification for the module cli? |
Mine doesn't. That's what I'm trying to do |
|
@Kwafoor |
This reverts commit c993c62.
# Conflicts: # common/src/test/java/org/apache/uniffle/common/metrics/TestUtils.java # coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/AdminResource.java # coordinator/src/main/java/org/apache/uniffle/coordinator/web/resource/ServerResource.java # integration-test/common/src/test/java/org/apache/uniffle/test/ServletTest.java
| ### Fetch shuffle servers | ||
|
|
||
| <details> | ||
| <summary><code>GET</code> <code><b>/api/server/nodes/{status}</b></code> </summary> |
There was a problem hiding this comment.
Could you update this part accordingly?
status should be a query parameter, right?
advancedxy
left a comment
There was a problem hiding this comment.
lgtm, except some comments regarding documentation.
advancedxy
left a comment
There was a problem hiding this comment.
LGTM.
The ut has one failure, maybe there's some flaky test.
Yes. #409 |
What changes were proposed in this pull request?
Apply REST principles in the urls of the http interfaces
Why are the changes needed?
Fix: #999
Does this PR introduce any user-facing change?
Env:
Server IP: 127.0.0.1
HTTP port: 19998
RPC port: 19999
Decommission single shuffle server example:
Cancel decommission single shuffle server example:
Fetch single shuffle server:
Fetch server list:
How was this patch tested?
UT