[#960][part-2] feat(dashboard): Add a dashboard front-end module. - #1055
Merged
Conversation
slfan1989
reviewed
Jul 31, 2023
roryqi
reviewed
Sep 1, 2023
yl09099
force-pushed
the
uniffle-960-2
branch
from
September 1, 2023 07:17
2aa11e9 to
f080f84
Compare
yl09099
force-pushed
the
uniffle-960-2
branch
6 times, most recently
from
September 1, 2023 11:09
877cd85 to
3010741
Compare
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
============================================
+ Coverage 53.35% 53.75% +0.39%
+ Complexity 2690 2161 -529
============================================
Files 410 333 -77
Lines 23590 15038 -8552
Branches 2003 1386 -617
============================================
- Hits 12587 8083 -4504
+ Misses 10229 6502 -3727
+ Partials 774 453 -321 see 79 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
yl09099
force-pushed
the
uniffle-960-2
branch
from
September 1, 2023 14:20
3010741 to
257bf50
Compare
yl09099
force-pushed
the
uniffle-960-2
branch
2 times, most recently
from
November 8, 2023 09:38
fcb6d2a to
390bfa1
Compare
Contributor
|
@xianjingfeng @leixm Could you help me review this pr? |
zuston
reviewed
Nov 10, 2023
yl09099
force-pushed
the
uniffle-960-2
branch
from
November 10, 2023 13:46
390bfa1 to
388891c
Compare
yl09099
force-pushed
the
uniffle-960-2
branch
from
November 10, 2023 15:01
388891c to
650ca76
Compare
zuston
approved these changes
Nov 15, 2023
zuston
left a comment
zuston
left a comment
Member
There was a problem hiding this comment.
lgtm. Waiting for other people’s reviews
Member
|
Merged. Thanks for your great contribution @yl09099 . Thanks for your review @jerqi @slfan1989 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a UI front-end file for dashboard, which have been verified it in DIDI's production:
Why are the changes needed?
Fix: #960
Does this PR introduce any user-facing change?
Add the web dashboard for coordinator
How was this patch tested?
UT.