[#825][part-7] feat(spark): Write Stage resubmit and dynamic shuffle server assign integration tests. - #1148
Merged
Merged
Conversation
yl09099
force-pushed
the
uniffle-825-7
branch
from
October 10, 2023 10:27
bd1547f to
64c4a68
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
============================================
+ Coverage 53.35% 54.48% +1.13%
- Complexity 2690 2696 +6
============================================
Files 410 391 -19
Lines 23590 21280 -2310
Branches 2003 2006 +3
============================================
- Hits 12587 11595 -992
+ Misses 10229 8980 -1249
+ Partials 774 705 -69 ☔ View full report in Codecov by Sentry. |
yl09099
force-pushed
the
uniffle-825-7
branch
from
November 10, 2023 13:30
c135820 to
f0f941f
Compare
Contributor
Author
|
@jerqi @leixm Look at it for me when you have time. |
yl09099
force-pushed
the
uniffle-825-7
branch
from
November 13, 2023 01:45
f0f941f to
a149665
Compare
leixm
reviewed
Nov 13, 2023
Contributor
There was a problem hiding this comment.
Could we reuse MockedShuffleServerGrpcService?
Contributor
|
Could you resolve this comment #1147 (comment) in this pr? |
Contributor
Author
I will submit this PR separately, and this integration test is a test of the above 6 PR, which is one. |
yl09099
force-pushed
the
uniffle-825-7
branch
from
November 14, 2023 03:53
a149665 to
c7ef109
Compare
…uffle server assign integration tests.
yl09099
force-pushed
the
uniffle-825-7
branch
from
November 14, 2023 03:55
c7ef109 to
348b270
Compare
Contributor
|
LGTM, @jerqi please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Write Stage resubmit and dynamic shuffle server assign integration tests.
Ⅰ. Overall objective:
Ⅱ. Implementation logic diagram:
Ⅲ. As shown in the picture above:
2, the Task of Stage starts, solid steps, in accordance with the green by ShuffleManager Client RPC interface gets to be written for shuffleIdToShuffleHandleInfo ShuffleServer list;
Why are the changes needed?
Fix: #825
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.