[MINOR] docs: Fix spark.serializer in README and client_guide - #1180
Merged
Conversation
roryqi
changed the title
roryqi
changed the title
roryqi
approved these changes
Aug 30, 2023
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @chqtan1993 , merged.
xianjingfeng
pushed a commit
that referenced
this pull request
Sep 14, 2023
### What changes were proposed in this pull request? before: <img width="973" alt="企业微信截图_59b6f770-e0c8-4274-86ef-4a0527d530cf" src="https://github.com/apache/incubator-uniffle/assets/70899573/b7e5eb68-b553-406a-bee5-2dede504abbb"> <img width="1005" alt="企业微信截图_ad7abd72-09e7-4b57-905f-a77f04428836" src="https://github.com/apache/incubator-uniffle/assets/70899573/2559bc7e-6446-48d9-b97b-873fc263e2fb"> after: <img width="959" alt="image" src="https://github.com/apache/incubator-uniffle/assets/70899573/16de72f9-b064-49aa-8a23-e130eeaf4ae8"> <img width="1037" alt="image" src="https://github.com/apache/incubator-uniffle/assets/70899573/882029f5-706b-481c-82db-414c10f03662"> ### Why are the changes needed?  If the wrong `spark.serialier` is set, the above error will be reported in registerShuffle, and `spark.serializer` should actually be used. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Screenshots attached. Co-authored-by: alexcqtan <alexcqtan@tencent.com> (cherry picked from commit ad9d0f1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
before:
after:
Why are the changes needed?
If the wrong
spark.serialieris set, the above error will be reported in registerShuffle, andspark.serializershould actually be used.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Screenshots attached.