[#1178] improvement: set rss.coordinator.quota.default.app.num default -1 to indicate no quota check - #1186
Merged
Conversation
…` default -1 to indicate no quota check
roryqi
reviewed
Sep 4, 2023
| applicationManager.getQuotaManager().checkQuota("user4", String.valueOf(i1)); | ||
| registerThread.join(); | ||
| assertTrue(icCheck); | ||
| assertFalse(icCheck); |
Contributor
There was a problem hiding this comment.
Could you add a case for rss.coordinator.quota.default.app.num = 5?
Contributor
Author
There was a problem hiding this comment.
I'll keep current testCheckQuota logic for test rss.coordinator.quota.default.app.num = 5, add a new testCheckQuotaWithDefault function to test default value -1.
Codecov Report
@@ Coverage Diff @@
## master #1186 +/- ##
============================================
+ Coverage 53.63% 54.71% +1.08%
Complexity 2581 2581
============================================
Files 391 371 -20
Lines 22407 20049 -2358
Branches 1875 1875
============================================
- Hits 12017 10969 -1048
+ Misses 9683 8442 -1241
+ Partials 707 638 -69
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1、set
rss.coordinator.quota.default.app.numdefault value as -12、the logic for quota check is the user app quota value < 0, then this user app quota check would passed
Why are the changes needed?
(Please clarify why the changes are needed. For instance,
Fix: # (#1178 )
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT