[#1192] improvement: Add RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLE conf for storing shuffle data - #1194
Merged
Conversation
…_ENABLE conf for storing shuffle data
roryqi
changed the title
Contributor
|
Could you add a doc if this pr introduce user-facing change? |
zuston
reviewed
Sep 13, 2023
| .booleanType() | ||
| .defaultValue(true) | ||
| .withDescription( | ||
| "Whether create proxy user for spark job user to visiting secured hadoop cluster."); |
Member
There was a problem hiding this comment.
description: Whether using proxy user for spark job user to access secured Hadoop cluster
Contributor
Author
done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
============================================
+ Coverage 53.64% 54.77% +1.12%
- Complexity 2584 2586 +2
============================================
Files 391 371 -20
Lines 22411 20065 -2346
Branches 1875 1875
============================================
- Hits 12023 10990 -1033
+ Misses 9682 8439 -1243
+ Partials 706 636 -70 ☔ View full report in Codecov by Sentry. |
roryqi
reviewed
Sep 13, 2023
| |rss.security.hadoop.kerberos.keytab.file|-|The kerberos keytab file path. And only when rss.security.hadoop.kerberos.enable is enabled, the option will be valid| | ||
| |rss.security.hadoop.kerberos.principal|-|The kerberos keytab principal. And only when rss.security.hadoop.kerberos.enable is enabled, the option will be valid| | ||
| |rss.security.hadoop.kerberos.relogin.interval.sec|60|The kerberos authentication relogin interval. unit: sec| | ||
| |rss.security.hadoop.kerberos.proxy.user.enable|true|Whether using proxy user for spark job user to access secured Hadoop cluster.| |
Contributor
There was a problem hiding this comment.
spark job -> job
MR jobs or Tez jobs may use this config option.
roryqi
reviewed
Sep 13, 2023
| .booleanType() | ||
| .defaultValue(true) | ||
| .withDescription( | ||
| "Whether using proxy user for spark job user to access secured Hadoop cluster."); |
zuston
approved these changes
Sep 13, 2023
Member
|
lgtm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add
RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLEwith default true,if set false, shuffle data storing in security hdfs use UGI user.
Why are the changes needed?
Fix: #1192
Does this PR introduce any user-facing change?
add
RSS_SECURITY_HADOOP_KERBEROS_PROXY_USER_ENABLEwith default trueHow was this patch tested?
add
HadoopSecurityContextTest.testSecuredDisableProxyUser()test case