Skip to content

[#1198] improvement: zerocopy from Protobuf's ByteString to Netty's ByteBuf - #1199

Merged
zuston merged 1 commit into
apache:masterfrom
zuston:issue-1198
Sep 16, 2023
Merged

[#1198] improvement: zerocopy from Protobuf's ByteString to Netty's ByteBuf#1199
zuston merged 1 commit into
apache:masterfrom
zuston:issue-1198

Conversation

@zuston

@zuston zuston commented Sep 15, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

zerocopy from Protobuf's ByteString to Netty's ByteBuf

Why are the changes needed?

#1198 . Improve the performance when using the GRpc

Does this PR introduce any user-facing change?

No.

How was this patch tested?

existing unit tests

@zuston
zuston requested review from leixm and roryqi September 15, 2023 09:44

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zuston

@zuston
zuston merged commit 3b37da5 into apache:master Sep 16, 2023
@zuston zuston linked an issue Sep 16, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] zerocopy from Protobuf's ByteString to Netty's ByteBuf

2 participants