Skip to content

[ISSUE-1204] chores(ci): Fix the ci pipeline of Kubernetes - #1205

Merged
zuston merged 1 commit into
apache:masterfrom
roryqi:ci
Sep 23, 2023
Merged

[ISSUE-1204] chores(ci): Fix the ci pipeline of Kubernetes#1205
zuston merged 1 commit into
apache:masterfrom
roryqi:ci

Conversation

@roryqi

@roryqi roryqi commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

The ci pipeline use the latest revive package. But the version v1.3.4 will cause the failure of CI. So I use the older version package to pass the CI pipeline
https://github.com/apache/incubator-uniffle/actions/runs/6273740844/job/17060784342

Why are the changes needed?

Fix: #1204

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI passed.

@roryqi roryqi changed the title [ISSUE-1204] build: Fix the ci pipeline of Kubernetes [ISSUE-1204] chores: Fix the ci pipeline of Kubernetes Sep 23, 2023
@roryqi roryqi changed the title [ISSUE-1204] chores: Fix the ci pipeline of Kubernetes [ISSUE-1204] chores(ci): Fix the ci pipeline of Kubernetes Sep 23, 2023
@roryqi
roryqi requested a review from kaijchen September 23, 2023 07:17
@codecov-commenter

codecov-commenter commented Sep 23, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1205 (6dc65a1) into master (ffb9870) will decrease coverage by 1.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1205      +/-   ##
============================================
- Coverage     55.02%   53.74%   -1.28%     
+ Complexity     2609     2598      -11     
============================================
  Files           372      392      +20     
  Lines         20114    22474    +2360     
  Branches       1884     1884              
============================================
+ Hits          11067    12078    +1011     
- Misses         8408     9688    +1280     
- Partials        639      708      +69     

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zuston
zuston merged commit 292ce65 into apache:master Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fix the ci pipeline of Kubernetes

3 participants