Skip to content

[#1090] refactor: Refactor the reader code with builder pattern - #1232

Merged
roryqi merged 6 commits into
apache:masterfrom
summaryzb:read_build
Oct 16, 2023
Merged

[#1090] refactor: Refactor the reader code with builder pattern#1232
roryqi merged 6 commits into
apache:masterfrom
summaryzb:read_build

Conversation

@summaryzb

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

As the title

Why are the changes needed?

#1090

Does this PR introduce any user-facing change?

No.

How was this patch tested?

unit test

@codecov-commenter

codecov-commenter commented Oct 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1232 (8e29447) into master (77092e4) will increase coverage by 1.23%.
The diff coverage is 54.77%.

@@             Coverage Diff              @@
##             master    #1232      +/-   ##
============================================
+ Coverage     53.57%   54.80%   +1.23%     
- Complexity     2613     2615       +2     
============================================
  Files           395      374      -21     
  Lines         22648    20339    -2309     
  Branches       1933     1937       +4     
============================================
- Hits          12133    11147     -986     
+ Misses         9774     8521    -1253     
+ Partials        741      671      -70     
Files Coverage Δ
...e/uniffle/client/factory/ShuffleClientFactory.java 93.26% <98.27%> (+27.69%) ⬆️
...pache/hadoop/mapreduce/task/reduce/RssShuffle.java 0.00% <0.00%> (ø)
...library/common/shuffle/impl/RssTezFetcherTask.java 0.00% <0.00%> (ø)
...on/shuffle/orderedgrouped/RssShuffleScheduler.java 46.17% <0.00%> (-0.62%) ⬇️
...che/uniffle/client/impl/ShuffleReadClientImpl.java 76.71% <56.86%> (-1.65%) ⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@summaryzb

Copy link
Copy Markdown
Contributor Author

@jerqi PTAL

@summaryzb summaryzb changed the title refactor: Refactor the reader code with builder pattern [#1090] refactor: Refactor the reader code with builder pattern Oct 14, 2023

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @summaryzb

@roryqi
roryqi merged commit f49b9de into apache:master Oct 16, 2023
@summaryzb
summaryzb deleted the read_build branch March 14, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants