improvement(rust): separate runtimes for different overload - #1233
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
============================================
+ Coverage 53.57% 54.61% +1.04%
Complexity 2613 2613
============================================
Files 395 375 -20
Lines 22648 20288 -2360
Branches 1933 1933
============================================
- Hits 12133 11080 -1053
+ Misses 9774 8539 -1235
+ Partials 741 669 -72 see 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
cc @jerqi Please help merge this |
roryqi
approved these changes
Oct 16, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In current codebase, we use the same tokio runtime for grpc/http/reading/flushing service, this is not
stable fot the different load.
This PR is to introduce runtime manager to separate.
Why are the changes needed?
For #1234 , separate runtimes for different overload
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UTs