[#1237] feat(rust): support populating args by clap - #1236
Merged
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
============================================
+ Coverage 53.85% 54.80% +0.94%
+ Complexity 2628 2615 -13
============================================
Files 394 374 -20
Lines 22699 20339 -2360
Branches 1937 1937
============================================
- Hits 12225 11146 -1079
+ Misses 9729 8521 -1208
+ Partials 745 672 -73 see 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Oct 16, 2023
advancedxy
approved these changes
Oct 16, 2023
zuston
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to support populating args by clap.
Why are the changes needed?
Before this, the config path is specified by the environment key, which is not elegant.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Existing tests.