[#1243] fix(test): Fix the flaky test SparkSQLTest and `Repartition… - #1244
Merged
Conversation
Contributor
Author
|
@jerqi @kaijchen PTAL |
summaryzb
force-pushed
the
flaky_test_npe
branch
from
October 17, 2023 17:28
8cac860 to
b27ee80
Compare
Contributor
|
@kaijchen Could you merge this pr to branch-0.8, too? |
kaijchen
pushed a commit
that referenced
this pull request
Oct 18, 2023
…Test` (#1244) ### What changes were proposed in this pull request? Remove static tmpDir field annotated with `@TempDir` of which their super class has the same field with the same annotation ### Why are the changes needed? When both static tmpDir field annotated with `@TempDir` exists, the tmpDir of the super class is not initialized by the junit framework, then NullPointerException occurs when call `IntegrationTestBase.getShuffleServerConf()` #1243 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? mvn -B package -Dtest=org.apache.uniffle.test.SparkSQLWithDelegationShuffleManagerTest -Pspark3 mvn -B package -Dtest=org.apache.uniffle.test.RepartitionWithLocalFileRssTest -Pspark3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove static tmpDir field annotated with
@TempDirof which their super class has the same field with the same annotationWhy are the changes needed?
When both static tmpDir field annotated with
@TempDirexists, the tmpDir of the super class is not initialized by the junit framework, then NullPointerException occurs when callIntegrationTestBase.getShuffleServerConf()#1243
Does this PR introduce any user-facing change?
No.
How was this patch tested?
mvn -B package -Dtest=org.apache.uniffle.test.SparkSQLWithDelegationShuffleManagerTest -Pspark3
mvn -B package -Dtest=org.apache.uniffle.test.RepartitionWithLocalFileRssTest -Pspark3