[#1254] fix(test): Fix the flaky test RssShuffleTest. - #1255
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
============================================
+ Coverage 54.17% 55.02% +0.84%
+ Complexity 2659 2646 -13
============================================
Files 396 376 -20
Lines 23013 20672 -2341
Branches 1971 1970 -1
============================================
- Hits 12467 11374 -1093
+ Misses 9777 8602 -1175
+ Partials 769 696 -73 see 29 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
approved these changes
Oct 23, 2023
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @zhengchenyu , merge to master & branch 0.8.
Contributor
|
@zhengchenyu https://github.com/apache/incubator-uniffle/actions/runs/6613073525/job/17960204522 The fix seems useless. |
Collaborator
Author
Oh, that's another unit test. I only fix one which I encountered in this PR, but miss another. I will submit a followup pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #1254
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test