[#1256] refactor: optimize collections contruction - #1257
Merged
Conversation
roryqi
changed the title
roryqi
reviewed
Oct 23, 2023
|
|
||
| private void sendBufferToServers(SortWriteBuffer<K, V> buffer) { | ||
| List<ShuffleBlockInfo> shuffleBlocks = Lists.newArrayList(); | ||
| List<ShuffleBlockInfo> shuffleBlocks = new ArrayList<>(1); |
Contributor
There was a problem hiding this comment.
Why is 1 is a reasonbale value?
Contributor
Author
There was a problem hiding this comment.
It's only used for adding one buffer
roryqi
reviewed
Oct 23, 2023
| Set<Long> result = taskToFailedBlockIds.get(taskId); | ||
| if (result == null) { | ||
| result = Sets.newHashSet(); | ||
| Collections.emptySet(); |
Contributor
There was a problem hiding this comment.
result = Collections.emptySet()?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
#1256
Does this PR introduce any user-facing change?
No.
How was this patch tested?
unit test