Skip to content

[#1261] fix(spark): Throw out InterruptedException for sleep in requestExecutorMemory - #1262

Merged
zuston merged 1 commit into
apache:masterfrom
wForget:UNIFFLE-1261
Oct 24, 2023
Merged

[#1261] fix(spark): Throw out InterruptedException for sleep in requestExecutorMemory#1262
zuston merged 1 commit into
apache:masterfrom
wForget:UNIFFLE-1261

Conversation

@wForget

@wForget wForget commented Oct 24, 2023

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

Pass InterruptedException in requestExecutorMemory.

Why are the changes needed?

Fix: #1261

Does this PR introduce any user-facing change?

No.

How was this patch tested?

@codecov-commenter

codecov-commenter commented Oct 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1262 (4983b5d) into master (49effee) will increase coverage by 1.10%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #1262      +/-   ##
============================================
+ Coverage     53.93%   55.03%   +1.10%     
  Complexity     2647     2647              
============================================
  Files           396      376      -20     
  Lines         23036    20676    -2360     
  Branches       1970     1970              
============================================
- Hits          12424    11379    -1045     
+ Misses         9845     8600    -1245     
+ Partials        767      697      -70     
Files Coverage Δ
...pache/spark/shuffle/writer/WriteBufferManager.java 82.97% <0.00%> (ø)

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@summaryzb

Copy link
Copy Markdown
Contributor

Good catch

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merged.

@zuston zuston changed the title [#1261] Pass InterruptedException in requestExecutorMemory [#1261] fix(spark): Throw out InterruptedException in requestExecutorMemory's sleep Oct 24, 2023
@zuston zuston changed the title [#1261] fix(spark): Throw out InterruptedException in requestExecutorMemory's sleep [#1261] fix(spark): Throw out InterruptedException for sleep in requestExecutorMemory Oct 24, 2023
@zuston
zuston merged commit 9dd4c4d into apache:master Oct 24, 2023
@roryqi

roryqi commented Oct 24, 2023

Copy link
Copy Markdown
Contributor

@zuston Should we merge this to branch 0.8, too?

@zuston

zuston commented Oct 24, 2023

Copy link
Copy Markdown
Member

@zuston Should we merge this to branch 0.8, too?

I think yes.

xianjingfeng pushed a commit that referenced this pull request Oct 31, 2023
…stExecutorMemory #1262

### What changes were proposed in this pull request?

Pass InterruptedException in requestExecutorMemory.

### Why are the changes needed?

Fix:  #1261

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.

(cherry picked from commit 9dd4c4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] InterruptedException should be passed in WriteBufferManager.requestExecutorMemory

5 participants