[#1277] chore: add flatten maven plugin - #1278
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
============================================
+ Coverage 54.12% 55.22% +1.09%
- Complexity 2516 2667 +151
============================================
Files 383 376 -7
Lines 21618 20697 -921
Branches 1841 1971 +130
============================================
- Hits 11700 11429 -271
+ Misses 9186 8572 -614
+ Partials 732 696 -36 see 37 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
approved these changes
Oct 30, 2023
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @xianjingfeng
Member
Author
|
Merged. Thanks @jerqi |
xianjingfeng
added a commit
that referenced
this pull request
Oct 31, 2023
### What changes were proposed in this pull request? add flatten maven plugin ### Why are the changes needed? If we add shaded module for clients, we must add flatten-maven-plugin, or the dependences in not-shaded module will not be included in the shaded jar. Fix: #1277 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? CI (cherry picked from commit 2808d25)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add flatten maven plugin
Why are the changes needed?
If we add shaded module for clients, we must add flatten-maven-plugin, or the dependences in not-shaded module will not be included in the shaded jar.
Fix: #1277
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI