[#1273] feat: add shaded module for spark3 client - #1279
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
============================================
+ Coverage 53.94% 55.04% +1.10%
+ Complexity 2655 2654 -1
============================================
Files 396 376 -20
Lines 23057 20697 -2360
Branches 1971 1971
============================================
- Hits 12437 11393 -1044
+ Misses 9854 8609 -1245
+ Partials 766 695 -71 see 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
approved these changes
Oct 30, 2023
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @xianjingfeng
xianjingfeng
added a commit
that referenced
this pull request
Oct 31, 2023
### What changes were proposed in this pull request? add shaded module for spark3 client ### Why are the changes needed? Fix: #1273 ### Does this PR introduce _any_ user-facing change? spark3 shaded jar is renamed to rss-client-spark3-shaded-${version}.jar ### How was this patch tested? CI (cherry picked from commit 7828558)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add shaded module for spark3 client
Why are the changes needed?
Fix: #1273
Does this PR introduce any user-facing change?
spark3 shaded jar is renamed to rss-client-spark3-shaded-${version}.jar
How was this patch tested?
CI