[MINOR] fix: missing to build spark shaded modules - #1282
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1282 +/- ##
============================================
+ Coverage 53.69% 54.78% +1.08%
- Complexity 2653 2654 +1
============================================
Files 398 378 -20
Lines 23157 20797 -2360
Branches 1976 1976
============================================
- Hits 12434 11393 -1041
+ Misses 9956 8709 -1247
+ Partials 767 695 -72 see 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roryqi
approved these changes
Oct 31, 2023
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @xianjingfeng
xianjingfeng
added a commit
that referenced
this pull request
Oct 31, 2023
### What changes were proposed in this pull request? Building spark shaded modules in build_distribution.sh ### Why are the changes needed? Spark shaded clients will be miss without this pr. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Manually execute build_distribution.sh (cherry picked from commit 73ae342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Building spark shaded modules in
build_distribution.shWhy are the changes needed?
Spark shaded clients will be miss without this pr.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually execute
build_distribution.sh