[#1293]feat(rust): Add total_read_data metric - #1298
Merged
zuston merged 8 commits intoNov 8, 2023
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1298 +/- ##
============================================
+ Coverage 53.67% 54.71% +1.04%
+ Complexity 2691 2690 -1
============================================
Files 403 383 -20
Lines 23456 21096 -2360
Branches 1992 1992
============================================
- Hits 12589 11542 -1047
+ Misses 10092 8851 -1241
+ Partials 775 703 -72 see 21 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
zuston
reviewed
Nov 6, 2023
added 2 commits
November 6, 2023 18:30
zuston
reviewed
Nov 7, 2023
zuston
left a comment
Member
There was a problem hiding this comment.
Overall the change looks good. left minor comments.
zuston
approved these changes
Nov 8, 2023
zuston
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for your contribution!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add total_received_data metric
(Please outline the changes and how this PR fixes the issue.)
Why are the changes needed?
Currently, the total_received_data metric has been introduced, the total_read_data is also necessary
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including
No.
How was this patch tested?
(Please test your changes, and provide instructions on how to test it: