Skip to content

[#1293]feat(rust): Add total_read_data metric - #1298

Merged
zuston merged 8 commits into
apache:masterfrom
wenlongbrother:users/wenlong/AddTotalReadDataMetric
Nov 8, 2023
Merged

[#1293]feat(rust): Add total_read_data metric#1298
zuston merged 8 commits into
apache:masterfrom
wenlongbrother:users/wenlong/AddTotalReadDataMetric

Conversation

@wenlongbrother

@wenlongbrother wenlongbrother commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add total_received_data metric

(Please outline the changes and how this PR fixes the issue.)

Why are the changes needed?

Currently, the total_received_data metric has been introduced, the total_read_data is also necessary

Does this PR introduce any user-facing change?

(Please list the user-facing changes introduced by your change, including

  1. Change in user-facing APIs.
  2. Addition or removal of property keys.)

No.

How was this patch tested?

(Please test your changes, and provide instructions on how to test it:

  1. If you add a feature or fix a bug, add a test to cover your changes.
  2. If you fix a flaky test, repeat it for many times to prove it works.)

@wenlongbrother wenlongbrother changed the title feat(rust) Add total_read_data metric feat(rust): Add total_read_data metric Nov 5, 2023
@wenlongbrother wenlongbrother changed the title feat(rust): Add total_read_data metric [#1293]feat(rust): Add total_read_data metric Nov 6, 2023
@roryqi
roryqi requested a review from zuston November 6, 2023 01:45
@codecov-commenter

codecov-commenter commented Nov 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1298 (56e8e5c) into master (59e08e5) will increase coverage by 1.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1298      +/-   ##
============================================
+ Coverage     53.67%   54.71%   +1.04%     
+ Complexity     2691     2690       -1     
============================================
  Files           403      383      -20     
  Lines         23456    21096    -2360     
  Branches       1992     1992              
============================================
- Hits          12589    11542    -1047     
+ Misses        10092     8851    -1241     
+ Partials        775      703      -72     

see 21 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Comment thread rust/experimental/server/src/store/hybrid.rs Outdated
@wenlongbrother
wenlongbrother requested a review from zuston November 6, 2023 10:32

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change looks good. left minor comments.

Comment thread rust/experimental/server/src/app.rs Outdated
@wenlongbrother
wenlongbrother requested a review from zuston November 7, 2023 11:05

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@zuston
zuston merged commit 23e26fc into apache:master Nov 8, 2023
@zuston zuston linked an issue Nov 8, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add the total_read_data metrics for rust based server

3 participants