Skip to content

[#1309] fix(spark): WriteBufferManager in Spark2 does not use a reassigned shuffle server. - #1310

Merged
roryqi merged 1 commit into
apache:masterfrom
yl09099:uniffle-1309
Nov 11, 2023
Merged

[#1309] fix(spark): WriteBufferManager in Spark2 does not use a reassigned shuffle server.#1310
roryqi merged 1 commit into
apache:masterfrom
yl09099:uniffle-1309

Conversation

@yl09099

@yl09099 yl09099 commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

In Spark2, after a write failure, ShuffleBlockInfo is not built using the new shuffle server after the shuffle server is reassigned.

Why are the changes needed?

Fix: #1309

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UT.

@yl09099

yl09099 commented Nov 10, 2023

Copy link
Copy Markdown
Contributor Author

@jerqi @leixm Found a BUG, review it for me sometime.

@roryqi roryqi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @yl09099

@roryqi roryqi changed the title [#1309][Bug][#825] WriteBufferManager in Spark2 does not use a reassigned shuffle server. [#1309] fix(spark): WriteBufferManager in Spark2 does not use a reassigned shuffle server. Nov 11, 2023
@roryqi
roryqi merged commit d5de299 into apache:master Nov 11, 2023
xianjingfeng pushed a commit that referenced this pull request Nov 17, 2023
…igned shuffle server. (#1310)

### What changes were proposed in this pull request?

In Spark2, after a write failure, ShuffleBlockInfo is not built using the new shuffle server after the shuffle server is reassigned.

### Why are the changes needed?

Fix: #1309

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing UT.

(cherry picked from commit d5de299)
xianjingfeng added a commit that referenced this pull request Nov 20, 2023
… a reassigned shuffle server. (#1310)"

This reverts commit 0da1dd1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][#825][part-3] WriteBufferManager in Spark2 does not use a reassigned shuffle server.

2 participants