[MINOR] test: flaky test ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest - #1320
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1320 +/- ##
============================================
+ Coverage 53.39% 54.42% +1.02%
Complexity 2695 2695
============================================
Files 411 391 -20
Lines 23640 21280 -2360
Branches 2006 2006
============================================
- Hits 12622 11581 -1041
+ Misses 10242 8994 -1248
+ Partials 776 705 -71 ☔ View full report in Codecov by Sentry. |
roryqi
approved these changes
Nov 17, 2023
roryqi
left a comment
roryqi
left a comment
Contributor
There was a problem hiding this comment.
LGTM.thanks @xianjingfeng
xianjingfeng
added a commit
that referenced
this pull request
Nov 20, 2023
…leDataTest (#1320) ### What changes were proposed in this pull request? fix flaky test ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest. ### Why are the changes needed? ShuffleTaskManagerTest.checkAndClearLeakShuffleDataTest:940 expected: <false> but was: <true> The cause of the problem: Application in shuffleTaskInfos is removed first, and then remove the directory in the local disk. Refer: org.apache.uniffle.server.ShuffleTaskManager#removeResources ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Repeat it for 100 times in my development enviroment. (cherry picked from commit e1a5499)
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
…leDataTest (apache#1320) ### What changes were proposed in this pull request? fix flaky test ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest. ### Why are the changes needed? ShuffleTaskManagerTest.checkAndClearLeakShuffleDataTest:940 expected: <false> but was: <true> The cause of the problem: Application in shuffleTaskInfos is removed first, and then remove the directory in the local disk. Refer: org.apache.uniffle.server.ShuffleTaskManager#removeResources ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Repeat it for 100 times in my development enviroment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix flaky test ShuffleTaskManagerTest#checkAndClearLeakShuffleDataTest.
Why are the changes needed?
ShuffleTaskManagerTest.checkAndClearLeakShuffleDataTest:940 expected:
<false> but was: <true>
The cause of the problem:
Application in
shuffleTaskInfosis removed first, and then remove the directory in the local disk.Refer: org.apache.uniffle.server.ShuffleTaskManager#removeResources
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Repeat it for 100 times in my development enviroment.