[MINOR] test: flaky test GrpcServerTest.testGrpcExecutorPool - #1321
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1321 +/- ##
============================================
+ Coverage 53.39% 54.40% +1.01%
Complexity 2695 2695
============================================
Files 411 391 -20
Lines 23640 21283 -2357
Branches 2006 2006
============================================
- Hits 12622 11580 -1042
+ Misses 10242 8997 -1245
+ Partials 776 706 -70 ☔ View full report in Codecov by Sentry. |
xianjingfeng
added a commit
that referenced
this pull request
Nov 20, 2023
### What changes were proposed in this pull request? fix flaky test GrpcServerTest.testGrpcExecutorPool ### Why are the changes needed? GrpcServerTest.testGrpcExecutorPool:83 expected: <1.0> but was: <0.0> The cause of the problem: The metric GRPC_SERVER_EXECUTOR_BLOCKING_QUEUE_SIZE_KEY is updated only when there is thread be executed. So if the first two threads have already started executing, and then the third thread is submitted, this metric will not be updated. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Repeat it for 100 times in my development enviroment. (cherry picked from commit 60e3be8)
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
…1321) ### What changes were proposed in this pull request? fix flaky test GrpcServerTest.testGrpcExecutorPool ### Why are the changes needed? GrpcServerTest.testGrpcExecutorPool:83 expected: <1.0> but was: <0.0> The cause of the problem: The metric GRPC_SERVER_EXECUTOR_BLOCKING_QUEUE_SIZE_KEY is updated only when there is thread be executed. So if the first two threads have already started executing, and then the third thread is submitted, this metric will not be updated. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Repeat it for 100 times in my development enviroment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
fix flaky test GrpcServerTest.testGrpcExecutorPool
Why are the changes needed?
GrpcServerTest.testGrpcExecutorPool:83 expected: <1.0> but was: <0.0>
The cause of the problem:
The metric
GRPC_SERVER_EXECUTOR_BLOCKING_QUEUE_SIZE_KEYis updated only when there is thread be executed. So if the first two threads have already started executing, and then the third thread is submitted, this metric will not be updated.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Repeat it for 100 times in my development enviroment.