Skip to content

[#1308] improvement(rust): detect whether data has been purged in UT - #1323

Merged
zuston merged 2 commits into
apache:masterfrom
wenlongbrother:users/wenlong/FixStagingBufferReferenceRemain
Nov 22, 2023
Merged

[#1308] improvement(rust): detect whether data has been purged in UT#1323
zuston merged 2 commits into
apache:masterfrom
wenlongbrother:users/wenlong/FixStagingBufferReferenceRemain

Conversation

@wenlongbrother

@wenlongbrother wenlongbrother commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

add code to improve purge unit test to detect whether arc reference is 0

Why are the changes needed?

Fix: #1308

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  1. UT

@wenlongbrother

wenlongbrother commented Nov 20, 2023

Copy link
Copy Markdown
Contributor Author

#1308 Hi @zuston , could you please help review this pr?
I add some code to improve purge unit test to detect whether arc reference is 0

@codecov-commenter

codecov-commenter commented Nov 20, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5de299) 53.35% compared to head (a1e4618) 54.48%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1323      +/-   ##
============================================
+ Coverage     53.35%   54.48%   +1.13%     
- Complexity     2690     2695       +5     
============================================
  Files           410      391      -19     
  Lines         23590    21283    -2307     
  Branches       2003     2006       +3     
============================================
- Hits          12587    11597     -990     
+ Misses        10229     8980    -1249     
+ Partials        774      706      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zuston zuston linked an issue Nov 22, 2023 that may be closed by this pull request
3 tasks
@zuston zuston changed the title [#1308] improvement: add code to improve purge unit test to detect whether arc reference is 0 [#1308] improvement(rust): detect whether data has been purged in UT Nov 22, 2023

@zuston zuston left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wenlongbrother

@zuston
zuston merged commit d72a483 into apache:master Nov 22, 2023
zuston pushed a commit to zuston/incubator-uniffle that referenced this pull request Jan 18, 2024
…in UT (apache#1323)

### What changes were proposed in this pull request?

add code to improve purge unit test to detect whether arc reference is 0

### Why are the changes needed?

Fix: apache#1308 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

1. UT

---------

Co-authored-by: 蒋文龙 <jiangwenlong@192.168.1.6>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] StagingBuffer reference remain when it has been deleted

3 participants