[#1110] improvement(coordinator): better support of remote storage config - #1329
Merged
Conversation
Member
Author
|
Could you help review this ? @zhengchenyu |
Contributor
|
@LuciferYang Could you help me review this pr? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
============================================
+ Coverage 53.47% 54.19% +0.71%
- Complexity 2695 2707 +12
============================================
Files 411 398 -13
Lines 23644 21505 -2139
Branches 2006 2036 +30
============================================
- Hits 12643 11654 -989
+ Misses 10225 9138 -1087
+ Partials 776 713 -63 ☔ View full report in Codecov by Sentry. |
LuciferYang
reviewed
Nov 26, 2023
Member
Author
|
Could you help review again? @LuciferYang |
Member
Author
|
Gentle ping @LuciferYang |
LuciferYang
previously approved these changes
Nov 29, 2023
LuciferYang
left a comment
LuciferYang
left a comment
Contributor
There was a problem hiding this comment.
+1, LGTM apart from the comments below
LuciferYang
approved these changes
Nov 29, 2023
Member
Author
|
Thanks @LuciferYang . Merged. |
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
…orage config format (apache#1329) Introduce the new `DynamicClientConfigService` to provide the pluggable reader for config file multi format. And it also is compatible with the original dynamic config format. This PR introduces the new yaml parser, which is recommended in the future, the storage's hadoop conf could be xml style or k1:v1 . The example as follows. ```yaml rssClientConf: k1: v1 k2: v2 remoteStorageInfos: hdfs://a-ns01: |+ <configuration> <property> <name>k1</name> <value>v1</value> </property> <property> <name>k2</name> <value>v2</value> </property> </configuration> hdfs://x-ns01: k1: v1 k2: v2 ``` Fix: apache#1110 No. 1. UTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce the new
DynamicClientConfigServiceto provide the pluggable reader for config file multi format.And it also is compatible with the original dynamic config format.
This PR introduces the new yaml parser, which is recommended in the future, the storage's hadoop conf could be xml style or k1:v1 . The example as follows.
Why are the changes needed?
Fix: #1110
Does this PR introduce any user-facing change?
No.
How was this patch tested?