[#901] feat(server): respect disk capacity watermark rather than uniffle capacity - #1337
Merged
Conversation
…n uniffle capacity
roryqi
reviewed
Nov 29, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1337 +/- ##
============================================
+ Coverage 53.16% 54.19% +1.02%
- Complexity 2691 2712 +21
============================================
Files 414 398 -16
Lines 23780 21531 -2249
Branches 2030 2040 +10
============================================
- Hits 12642 11668 -974
+ Misses 10359 9149 -1210
+ Partials 779 714 -65 ☔ View full report in Codecov by Sentry. |
awdavidson
reviewed
Nov 29, 2023
| .highWaterMarkOfWrite(highWaterMarkOfWrite) | ||
| .localStorageMedia(storageType) | ||
| .build(); | ||
| .enableDiskCapacityWatermarkCheck(); |
Contributor
There was a problem hiding this comment.
It does not look like this line is intended?
Member
Author
There was a problem hiding this comment.
My fault. It has been removed.
Member
Author
|
PTAL @jerqi |
roryqi
approved these changes
Dec 2, 2023
3 tasks
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
…n uniffle capacity (apache#1337) ### What changes were proposed in this pull request? respect disk capacity watermark rather than uniffle capacity ### Why are the changes needed? Fix: apache#901 ### Does this PR introduce _any_ user-facing change? Yes. `rss.server.disk-capacity.watermark.check.enabled` is introduced. ### How was this patch tested? UTs
zuston
pushed a commit
to zuston/incubator-uniffle
that referenced
this pull request
Jan 18, 2024
[apache#901] feat(server): respect disk capacity watermark rather than uniffle capacity (apache#1337) See merge request !94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
respect disk capacity watermark rather than uniffle capacity
Why are the changes needed?
Fix: #901
Does this PR introduce any user-facing change?
Yes.
rss.server.disk-capacity.watermark.check.enabledis introduced.How was this patch tested?
UTs